wgtmac commented on code in PR #47835:
URL: https://github.com/apache/arrow/pull/47835#discussion_r2437847487
##########
cpp/src/parquet/parquet.thrift:
##########
@@ -410,7 +410,7 @@ struct BsonType {
struct VariantType {
// The version of the variant specification that the variant was
// written with.
- 1: optional i8 specification_version
+ 1: optional i8 specification_version = 1
Review Comment:
Instead, I'd suggest adding `int8_t specification_version_` to
`parquet::VariantLogicalType` and deal with thrift
serialization/deserialization there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]