[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #9758: ARROW-9054: [C++] Add ScalarAggregateOptions

[GitBox]

jorisvandenbossche commented on a change in pull request #9758:
URL: https://github.com/apache/arrow/pull/9758#discussion_r615670217



##########
File path: cpp/src/arrow/compute/kernels/aggregate_basic.cc
##########
@@ -232,9 +238,9 @@ namespace {
 
 const FunctionDoc count_doc{"Count the number of null / non-null values",
                             ("By default, non-null values are counted.\n"
-                             "This can be changed through CountOptions."),
+                             "This can be changed through 
ScalarAggregateOptions."),
                             {"array"},
-                            "CountOptions"};
+                            "ScalarAggregateOptions"};
 
 const FunctionDoc sum_doc{
     "Sum values of a numeric array", ("Null values are ignored."), {"array"}};

Review comment:
       Can you update the docstring here as well? (and the same for "mean" 
below)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org