scovich commented on PR #8481: URL: https://github.com/apache/arrow-rs/pull/8481#issuecomment-3353837180
> > > It seems to me like the `unshred_variant` in this PR subsumes the code in `cast_to_variant` -- we could probably switch `cast_to_variant` to create a "dummy" variant array and call into `unshred_variant` 🤔 > > > > > > There's definitely some overlap and I may have missed some opportunities for builder code reuse, but the two functions are not doing the same thing: > > I didn't mean to imply this PR should be changed I think now that https://github.com/apache/arrow-rs/pull/8519 has merged, it should be straightforward to coalesce some of the similar code between the two modules. Definitely a follow-up item tho. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
