etseidl commented on code in PR #8642:
URL: https://github.com/apache/arrow-rs/pull/8642#discussion_r2440541131
##########
parquet/src/bin/parquet-rewrite.rs:
##########
@@ -216,8 +174,8 @@ struct Args {
output: String,
/// Compression used for all columns.
- #[clap(long, value_enum)]
- compression: Option<CompressionArgs>,
+ #[clap(long)]
+ compression: Option<Compression>,
Review Comment:
I'm not sure I follow, won't the default level still be `1`? Or is it that
now one must provide the level on the command line as `--compression zstd(3)`?
##########
parquet/src/bin/parquet-rewrite.rs:
##########
@@ -47,48 +47,6 @@ use parquet::{
},
};
-#[derive(Copy, Clone, PartialEq, Eq, PartialOrd, Ord, ValueEnum, Debug)]
Review Comment:
One point of this structure is to provide documentation. With your change
help now looks like:
```
% ./target/debug/parquet-rewrite --help
Read and write parquet file with potentially different settings
Usage: parquet-rewrite [OPTIONS] --input <INPUT> --output <OUTPUT>
Options:
-i, --input <INPUT>
Path to input parquet file
-o, --output <OUTPUT>
Path to output parquet file
--compression <COMPRESSION>
Compression used for all columns
```
where before the compression help was:
```
--compression <COMPRESSION>
Compression used
Possible values:
- none: No compression
- snappy: Snappy
- gzip: GZip
- lzo: LZO
- brotli: Brotli
- lz4: LZ4
- zstd: Zstd
- lz4-raw: LZ4 Raw
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
