simonelbaz commented on code in PR #47599: URL: https://github.com/apache/arrow/pull/47599#discussion_r2426250113
########## r/R/dataset-write.R: ########## Review Comment: Thanks @thisisnic for taking the time to read my PR. From what I can read, `check_directory_existence_before_creation` is used at lines: - https://github.com/apache/arrow/blob/be6dddf228f73dafc34dafbe1343dc6a6680eb97/cpp/src/arrow/filesystem/s3fs.cc#L3188 - https://github.com/apache/arrow/blob/be6dddf228f73dafc34dafbe1343dc6a6680eb97/cpp/src/arrow/filesystem/s3fs.cc#L3239 to verify directory existence before creation. If `recursive` is set to TRUE (default value), the bucket and all directories in the document path will be checked and created if missing. This is why ListBucket and HeadBucket ACL are needed. In case `recursive` variable is set to `FALSE`, it will only verify if the parent directory exists. Maybe it would be more appropriate to use `recursively_check_and_create_missing_directories` instead of `create_directory`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
