alamb commented on code in PR #8638:
URL: https://github.com/apache/arrow-rs/pull/8638#discussion_r2441083307
##########
parquet-variant-compute/src/variant_to_arrow.rs:
##########
@@ -545,3 +557,21 @@ impl VariantToBinaryVariantArrowRowBuilder {
Ok(ArrayRef::from(variant_array))
}
}
+
+trait AppendValueTrait {
+ // NullBuilder will always append `()`
+ fn append_value(&mut self, v: ());
+}
+
+impl AppendValueTrait for NullBuilder {
Review Comment:
The NullArray is kind of strange -- maybe rather than creating a full on
builder for it, we could just keep count and then create the output array with
https://docs.rs/arrow/latest/arrow/array/fn.new_null_array.html ?
##########
parquet-variant-compute/src/variant_array.rs:
##########
@@ -1004,6 +1036,19 @@ fn typed_value_to_variant<'a>(
index
)
}
+ DataType::Time64(TimeUnit::Microsecond) => {
Review Comment:
Another possible type is `DataType::Time64(TimeUnit::Nanosecond)`
There is also a Time32 type in arrow:
https://docs.rs/arrow/latest/arrow/datatypes/enum.DataType.html#variant.Time32
I am not sure if we want to handle that too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
