jhorstmann commented on PR #8636: URL: https://github.com/apache/arrow-rs/pull/8636#issuecomment-3417237458
> Love it. It is a fascinating observation that constructing errors with strings (even when they aren't constructed) can slow our code down It is, and I also don't really know how much of that is because of removing the error message formatting code, vs the smaller size of the error type. The former might just have influenced some heuristics around inlining. I could imagine that C++ is actually smarter about eliminating redundant moves of such error structs. > I wonder how many other codepaths in arrow/parquet have the same property 🤔 I think you'd need a really high ratio of error handling vs "real" compute for that to have a measurable effect. Thrift parsing unfortunately needs error handling for nearly every byte, that shouldn't the case for other places in the code base. Hmm, maybe the checked arithmetic kernels would actually also benefit from a separate error type. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
