a10y commented on code in PR #8645:
URL: https://github.com/apache/arrow-rs/pull/8645#discussion_r2441306657
##########
arrow-data/src/data.rs:
##########
@@ -980,7 +980,15 @@ impl ArrayData {
) -> Result<(), ArrowError> {
let offsets: &[T] = self.typed_buffer(0, self.len)?;
let sizes: &[T] = self.typed_buffer(1, self.len)?;
- for i in 0..values_length {
Review Comment:
This was a bug before. You can verify this by construction a list_view_array
and then doing `list_view_array.to_data().into_builder().build().unwrap()` and
it will panic, because values_length is the length of the inner values not of
the list itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
