henryharbeck commented on code in PR #3556:
URL: https://github.com/apache/arrow-adbc/pull/3556#discussion_r2423375875
##########
python/adbc_driver_manager/adbc_driver_manager/_lib.pyi:
##########
@@ -145,16 +145,21 @@ class ArrowArrayHandle:
address: int
is_valid: bool
def release(self) -> None: ...
+ def __arrow_c_array__(
+ self, requested_schema: object | None
+ ) -> tuple[object, object]: ...
class ArrowArrayStreamHandle:
address: int
is_valid: bool
def release(self) -> None: ...
+ def __arrow_c_stream__(self, requested_schema: object | None) -> object:
...
class ArrowSchemaHandle:
address: int
is_valid: bool
def release(self) -> None: ...
+ def __arrow_c_schema__(self) -> object: ...
Review Comment:
This makes the type checker not complain about `polars.Schema(handle)`.
Figured it would be worth adding the other `__arrow_c_...` methods to the
stubs too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
