alamb commented on code in PR #8626:
URL: https://github.com/apache/arrow-rs/pull/8626#discussion_r2432860896
##########
parquet/src/encryption/encrypt.rs:
##########
@@ -275,14 +275,14 @@ impl EncryptionPropertiesBuilder {
}
/// Build the encryption properties
- pub fn build(self) -> Result<FileEncryptionProperties> {
- Ok(FileEncryptionProperties {
+ pub fn build(self) -> Result<Arc<FileEncryptionProperties>> {
Review Comment:
this is the main API change, and the rest of the changes mostly follow from
here
##########
parquet/tests/encryption/encryption_async.rs:
##########
@@ -471,7 +471,7 @@ async fn verify_encryption_test_file_read_async(
async fn read_and_roundtrip_to_encrypted_file_async(
path: &str,
decryption_properties: Arc<FileDecryptionProperties>,
- encryption_properties: FileEncryptionProperties,
+ encryption_properties: Arc<FileEncryptionProperties>,
Review Comment:
this is now nicely symmetric which I think is a good sign
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
