domoritz commented on code in PR #299:
URL: https://github.com/apache/arrow-js/pull/299#discussion_r2433229037
##########
test/generate-test-data.ts:
##########
@@ -493,6 +498,21 @@ function generateList<T extends List>(this:
TestDataVectorGenerator, type: T, le
return { values, vector: new Vector([makeData({ type, length, nullCount,
nullBitmap, valueOffsets, child: childVec.data[0] })]) };
}
+function generateLargeList<T extends LargeList>(this: TestDataVectorGenerator,
type: T, length = 100, nullCount = Math.trunc(length * 0.2), child =
this.visit(type.children[0].type, length * 3, nullCount * 3)):
GeneratedVector<T> {
Review Comment:
This seems to have a lot of overlap with the method above. Can we extract
the logic into a helper so we don't blow up code size?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
