jorisvandenbossche commented on a change in pull request #10074:
URL: https://github.com/apache/arrow/pull/10074#discussion_r615793101
##########
File path: python/pyarrow/parquet.py
##########
@@ -1244,7 +1255,7 @@ def __init__(self, path_or_paths, filesystem=None,
schema=None,
metadata=None, split_row_groups=False, validate_schema=True,
filters=None, metadata_nthreads=1, read_dictionary=None,
memory_map=False, buffer_size=0, partitioning="hive",
- use_legacy_dataset=True):
+ use_legacy_dataset=True, pre_buffer=True):
Review comment:
Ah, yes, since `pre_buffer=False` means to not do anything, it's indeed
fine to "ignore" it.
As you say, we could do some extra work to let it error on `pre_buffer=True`
(for the legacy implementation), but since it's clearly documented to be only
for the new version, I think it's fine to leave it as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
