CurtHagenlocher commented on code in PR #3551:
URL: https://github.com/apache/arrow-adbc/pull/3551#discussion_r2415400961
##########
csharp/src/Apache.Arrow.Adbc/Apache.Arrow.Adbc.csproj:
##########
@@ -10,7 +10,7 @@
<PackageReference Include="System.Diagnostics.DiagnosticSource"
Version="9.0.6" />
</ItemGroup>
<ItemGroup
Condition="!$([MSBuild]::IsTargetFrameworkCompatible($(TargetFramework),
'net6.0'))">
- <PackageReference Include="System.Text.Json" Version="8.0.5" />
+ <PackageReference Include="System.Text.Json" Version="9.0.0" />
Review Comment:
Is there a specific need to update System.Text.Json and ApacheThrift (or
benefit from updating them)? And why System.Text.Json 9.0.0 vs 9.0.9?
If there's not a specific need to update package versions then I'd just as
soon not do it as it can be mildly disruptive downstream.
##########
csharp/src/Drivers/Apache/Hive2/HiveServer2Connection.cs:
##########
@@ -405,6 +421,11 @@ await this.TraceActivity(async activity =>
{
throw new TimeoutException("The operation timed out while
attempting to open a session. Please try increasing connect timeout.", ex);
}
+ catch (TTransportException transportEx)
+ when (ApacheUtility.ContainsException(transportEx, out
HttpRequestException? httpEx) && IsUnauthorized(httpEx!))
+ {
+ throw new HiveServer2Exception("OpenAsync failed",
AdbcStatusCode.Unauthorized);
Review Comment:
In the other `catch (TTransportException transportEx)` we preserve the error
message from the original exception and attach it as an inner exception to the
`HiveServer2Exception`. Why is this different?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
