AntoinePrv commented on code in PR #47573:
URL: https://github.com/apache/arrow/pull/47573#discussion_r2428963471
##########
cpp/src/arrow/util/bit_stream_utils_internal.h:
##########
@@ -296,6 +296,18 @@ inline bool BitReader::GetValue(int num_bits, T* v) {
return GetBatch(num_bits, v, 1) == 1;
}
+namespace internal_bit_reader {
+template <typename T>
+struct unpack_detect {
+ using type = std::make_unsigned_t<T>;
+};
+
+template <>
+struct unpack_detect<bool> {
+ using type = uint8_t;
+};
Review Comment:
Good catch! Well since `unpack<uint8_t>` has a `static_cast` loop that's
gonna be easy to extend.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
