ayushbansal07 commented on code in PR #47629:
URL: https://github.com/apache/arrow/pull/47629#discussion_r2373046990
##########
cpp/src/arrow/util/io_util.cc:
##########
@@ -1070,11 +1070,10 @@ Result<FileDescriptor> FileOpenReadable(const
PlatformFilename& file_name) {
}
fd = FileDescriptor(ret);
#else
- int ret = open(file_name.ToNative().c_str(), O_RDONLY);
- if (ret < 0) {
- return IOErrorFromErrno(errno, "Failed to open local file '",
file_name.ToString(),
- "'");
- }
+ int64_t ret;
Review Comment:
yes, right. I saw this being done in some other part of code and did the
same thing, but then I realised open() return int and those calls returned
ssize_t. Have updated now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
