rluvaton commented on code in PR #8496:
URL: https://github.com/apache/arrow-rs/pull/8496#discussion_r2413598716
##########
parquet/src/arrow/schema/complex.rs:
##########
@@ -72,6 +72,52 @@ impl ParquetField {
}
}
+ /// Converts `self` into an arrow list, with its current type as the field
type
+ /// accept an optional `list_data_type` to specify the type of list to
create
+ ///
+ /// This is used to convert deprecated repeated columns (not in a list),
into their arrow representation
+ fn into_list_with_arrow_list_hint(
+ self,
+ parquet_field_type: &Type,
+ list_data_type: Option<DataType>,
+ ) -> Result<Self, ParquetError> {
+ let arrow_field = match &list_data_type {
+ Some(DataType::List(field_hint))
+ | Some(DataType::LargeList(field_hint))
+ | Some(DataType::FixedSizeList(field_hint, _)) =>
Some(field_hint.as_ref()),
+ Some(_) => unreachable!(
+ "should be validated earlier that list_data_type is only a
type of list"
Review Comment:
updated
##########
parquet/src/arrow/schema/complex.rs:
##########
@@ -72,6 +72,52 @@ impl ParquetField {
}
}
+ /// Converts `self` into an arrow list, with its current type as the field
type
+ /// accept an optional `list_data_type` to specify the type of list to
create
+ ///
+ /// This is used to convert deprecated repeated columns (not in a list),
into their arrow representation
Review Comment:
exactly, updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
