nathaniel-d-ef commented on code in PR #8595:
URL: https://github.com/apache/arrow-rs/pull/8595#discussion_r2429072021
##########
arrow-avro/src/writer/encoder.rs:
##########
@@ -1118,6 +1238,32 @@ impl<'a, P: ArrowPrimitiveType<Native = i64>>
LongEncoder<'a, P> {
}
}
+/// Time32(Second) to Avro time-millis (int), via safe scaling by 1000
+struct Time32SecondsToMillisEncoder<'a>(&'a PrimitiveArray<Time32SecondType>);
Review Comment:
It might be a bit DRYer to have these implement a `SecondsToMillis` trait or
something. I'm okay with this for our needs now though, unless you feel like
making that change.
##########
arrow-avro/src/schema.rs:
##########
@@ -428,25 +434,29 @@ impl AvroSchema {
build_canonical(schema, None)
}
- /// Build Avro JSON from an Arrow [`ArrowSchema`], applying the given
null‑union order.
+ /// Build Avro JSON from an Arrow [`ArrowSchema`], applying the given
null‑union order and optionally stripping internal Arrow metadata.
Review Comment:
Is there a chance we run into issues here with an all-or-nothing approach to
removing? Isn't the metadata simply ignored downstream unless it's specifically
being referenced?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
