adamreeve commented on code in PR #8621:
URL: https://github.com/apache/arrow-rs/pull/8621#discussion_r2433387044
##########
parquet/src/arrow/arrow_writer/mod.rs:
##########
@@ -872,6 +872,11 @@ impl ArrowColumnWriter {
}
/// Encodes [`RecordBatch`] to a parquet row group
+///
+/// You can create this structure via an [`ArrowRowGroupWriterFactory`]
+///
+/// See the example on [`ArrowColumnWriter`] for how to encode columns in
parallel
Review Comment:
`ArrowRowGroupWriter` is actually not public and not used in the
`ArrowColumnWriter` example, so this last sentence might be a little confusing.
(`ArrowRowGroupWriterFactory` is internally used to create
`ArrowRowGroupWriter`s, but publicly it only exposes the ability to create a
`Vec<ArrowColumnWriter>`. If I was starting this again from scratch I might
have named things a little differently...)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
