westonpace commented on a change in pull request #10008: URL: https://github.com/apache/arrow/pull/10008#discussion_r616012753
########## File path: cpp/src/arrow/dataset/scanner.h ########## @@ -51,6 +52,8 @@ constexpr int64_t kDefaultBatchSize = 1 << 20; constexpr int32_t kDefaultBatchReadahead = 32; constexpr int32_t kDefaultFragmentReadahead = 8; +using FragmentGenerator = std::function<Future<std::shared_ptr<Fragment>>()>; Review comment: I was able to move FragmentGenerator but `async_generator.h` was still needed for `Enumerated` which is a pity since `Enumerated` is small and self-contained. Should I place it in its own file? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org