raulcd commented on code in PR #47454:
URL: https://github.com/apache/arrow/pull/47454#discussion_r2405784180


##########
python/pyarrow/scalar.pxi:
##########
@@ -1173,7 +1173,7 @@ cdef class MapScalar(ListScalar, Mapping):
         if not maps_as_pydicts:
             return list(self)
         result_dict = {}
-        for key, value in self:
+        for key, value in zip(self.keys(), 
self.values.field(self.type.item_field.name)):

Review Comment:
   I see, that makes sense, thanks for the clarification, should we validate 
`self.values` is not `None` as we currently do on `__iter__`?
   ```python
           arr = self.values
           if arr is None:
               return
           for k, v in zip(arr.field(self.type.key_field.name), 
arr.field(self.type.item_field.name)):
               yield (k.as_py(), v.as_py())
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to