dreamtalen commented on PR #496: URL: https://github.com/apache/arrow-rs-object-store/pull/496#issuecomment-3354908773
> Thanks for this contribution @dreamtalen -- this code looks good to me > > Can you please add a test to this code? Maybe just a unit test that shows a `create_multipart` request has the expected content length? I am worried that we would lose this feature in some future refactor and not know about it > > Also, have you tested this code in your own environment and verified it works? Thanks for the review. A unit test is added and I verified this change makes MPU work correctly for both GCS and AWS S3 with the S3Client. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
