wgtmac commented on code in PR #47758:
URL: https://github.com/apache/arrow/pull/47758#discussion_r2415426083
##########
cpp/src/arrow/dataset/file_parquet.h:
##########
@@ -92,6 +92,7 @@ class ARROW_DS_EXPORT ParquetFileFormat : public FileFormat {
arrow::TimeUnit::type coerce_int96_timestamp_unit = arrow::TimeUnit::NANO;
Type::type binary_type = Type::BINARY;
Type::type list_type = Type::LIST;
+ uint32_t max_page_header_size = 0;
Review Comment:
Why 0 but not a meaningful default?
##########
cpp/src/parquet/properties.h:
##########
@@ -57,6 +57,9 @@ enum class SizeStatisticsLevel : uint8_t {
PageAndColumnChunk
};
+// 16 MB is the default maximum page header size
+static constexpr uint32_t kDefaultMaxPageHeaderSize = 16 * 1024 * 1024;
Review Comment:
```suggestion
constexpr uint32_t kDefaultMaxPageHeaderSize = 16 * 1024 * 1024;
```
##########
cpp/src/parquet/column_reader.cc:
##########
@@ -260,7 +261,7 @@ class SerializedPageReader : public PageReader {
// Fills in data_page_statistics.
bool ShouldSkipPage(EncodedStatistics* data_page_statistics);
Review Comment:
I'd suggest keeping it as `const`. We can change the function
`set_max_page_header_size` to do nothing after this PR and mark it as
deprecated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
