alamb opened a new issue, #8517:
URL: https://github.com/apache/arrow-rs/issues/8517

   **Is your feature request related to a problem or challenge? Please describe 
what you are trying to do.**
   I ran into this while working on the benchmark here
   -  https://github.com/apache/arrow-rs/issues/8441
   
   I noticed a substantial amount of time (15% of the overall time) in the 
benchmark was spent in `convert_row_groups`
   
   
https://github.com/apache/arrow-rs/blob/b4b4d261cad97fa37630756ff22cdce73cd25db4/parquet/src/file/metadata/thrift_gen.rs#L247-L257
   
   <img width="1386" height="577" alt="Image" 
src="https://github.com/user-attachments/assets/87746b9d-e3e1-4e5e-bfd6-4521f12d9f76";
 />
   
   **Describe the solution you'd like**
   I think that code could likely be optimized. 
   
   
   **Describe alternatives you've considered**
   Two obvious candidates:
   1. Use the `into_iter()` / `collect` pattern to map the results (which is 
highly optimized in Rust)
   2. Don't clone the `Arc<SchemaDescriptor>` -- I think it only needs a 
reference
   
   Another thing would be to decode directly into RowGroupMetaData somehow 
(maybe make RowGRoupMetaData a view on an inner RowGroup 🤔 
   
   ```rust
   struct RowGroupMetaData {
     inner: RowGroup
   }
   ```
   
   **Additional context**
   <!--
   Add any other context or screenshots about the feature request here.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to