lichuang commented on code in PR #8593:
URL: https://github.com/apache/arrow-rs/pull/8593#discussion_r2425174467
##########
parquet/benches/metadata.rs:
##########
@@ -64,13 +65,15 @@ fn encoded_meta() -> Vec<u8> {
})
}
- let stats = parquet::format::Statistics {
+ let max_value_binding = vec![rng.random(); 8];
Review Comment:
but the bin file parquet-layout.rs also use the `PageHeader` struct, which
is visible only in crate:
```rust
thrift_struct!(
pub(crate) struct PageHeader {
/// the type of the page: indicates which of the *_header fields is set
1: required PageType r#type
/// Uncompressed page size in bytes (not including this header)
2: required i32 uncompressed_page_size
/// Compressed (and potentially encrypted) page size in bytes, not
including this header
3: required i32 compressed_page_size
/// The 32-bit CRC checksum for the page, to be be calculated as follows:
4: optional i32 crc
// Headers for page specific data. One only will be set.
5: optional DataPageHeader data_page_header;
6: optional IndexPageHeader index_page_header;
7: optional DictionaryPageHeader dictionary_page_header;
8: optional DataPageHeaderV2 data_page_header_v2;
}
);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
