raulcd commented on PR #47827:
URL: https://github.com/apache/arrow/pull/47827#issuecomment-3414642951
> Does this work?
>
> ```diff
> diff --git a/dev/tasks/macros.jinja b/dev/tasks/macros.jinja
> index ddcb0d554e..76c67d1de0 100644
> --- a/dev/tasks/macros.jinja
> +++ b/dev/tasks/macros.jinja
> @@ -286,7 +286,7 @@ env:
> run: |
> profile_path <- file.path(getwd(), ".Rprofile")
> repo <- paste0("file://", getwd(), "/repo")
> - str <- paste0("options(arrow.repo = '", repo, "' )")
> + str <- paste0("options(arrow.repo = '", repo, "/' )")
> print(str)
> write(str, file = profile_path, append = TRUE)
> str <- paste0("options(arrow.dev_repo = '", repo, "' )")
> ```
>
I don't think that would work, this is logically the same change we did
initially on the release candidate:
```diff
diff --git a/dev/tasks/macros.jinja b/dev/tasks/macros.jinja
index ddcb0d554e..5b1a17d6b7 100644
--- a/dev/tasks/macros.jinja
+++ b/dev/tasks/macros.jinja
@@ -285,7 +285,7 @@ env:
shell: Rscript {0}
run: |
profile_path <- file.path(getwd(), ".Rprofile")
- repo <- paste0("file://", getwd(), "/repo")
+ repo <- paste0("file://", getwd(), "/repo/")
str <- paste0("options(arrow.repo = '", repo, "' )")
print(str)
write(str, file = profile_path, append = TRUE)
```
but then it was trying to locate the files here and failing to do so:
`file:///__w/crossbow/crossbow/repo/r-libarrow-linux-x86_64-openssl-3.0-22.0.0.zip`
that's why I updated the download path for the artifacts.
The problem is that `arrow.dev_repo` will still try to locate on
`repo/libarrow/r-libarrow-linux-x86_64-openssl-3.0-22.0.0.zip`.
I also am not comfortable of doing a lot of changes on the "release" one
because I can't really test it.
I'd rather adapt `arrow.dev_repo` and if required fix other areas related to
the `dev_repo` as we know with the first commit the rc job is successful.
I am also happy if someone else wants to take this over as this is the first
time I am looking at this and seems slightly convoluted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
