alamb commented on code in PR #8620:
URL: https://github.com/apache/arrow-rs/pull/8620#discussion_r2436407855
##########
arrow-buffer/src/util/bit_chunk_iterator.rs:
##########
@@ -221,7 +221,10 @@ pub struct BitChunks<'a> {
impl<'a> BitChunks<'a> {
/// Create a new [`BitChunks`] from a byte array, and an offset and length
in bits
pub fn new(buffer: &'a [u8], offset: usize, len: usize) -> Self {
- assert!(ceil(offset + len, 8) <= buffer.len() * 8);
+ assert!(
Review Comment:
The issue is that `buffer.len()` is already in bytes, right? So multiplying
by `8` scales it too much
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
