scovich opened a new pull request, #8580: URL: https://github.com/apache/arrow-rs/pull/8580
# Which issue does this PR close? - Closes https://github.com/apache/arrow-rs/issues/8579 # Rationale for this change Bug fix # What changes are included in this PR? Detect and directly handle large scale reductions, instead of failing on accident because the computed divisor overflows. Also, replace the `pow_checked` call with a lookup into the (already existing) `MAX_DECIMALXX_FOR_EACH_PRECISION` array. This requires adding a new `MAX_FOR_EACH_PRECISION` constant to the `DecimalType` trait, but the corresponding arrays were already public so this seems ok? # Are these changes tested? New unit tests exercise the scenario (and its boundary case). The tests fail without this fix. # Are there any user-facing changes? New constant on the public `DecimalType` trait. A class of decimal conversions that used to fail will now (correctly) produce zeros instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
