etseidl commented on code in PR #8476:
URL: https://github.com/apache/arrow-rs/pull/8476#discussion_r2382947128
##########
parquet/src/basic.rs:
##########
@@ -59,10 +59,14 @@ enum Type {
);
// ----------------------------------------------------------------------
-// Mirrors thrift enum `crate::format::ConvertedType`
+// Mirrors thrift enum `ConvertedType`
//
// Cannot use macros because of added field `None`
+// TODO(ets): Adding the `NONE` variant to this enum is a bit awkward. We
should
+// look into removing it and using `Option<ConvertedType>` instead. Then all
of this
+// handwritten code could go away.
Review Comment:
I went down this path, and it creates a lot of changes (and would be another
breaking change). I don't know if the juice is worth the squeeze.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
