paleolimbot commented on code in PR #8524:
URL: https://github.com/apache/arrow-rs/pull/8524#discussion_r2411934894
##########
parquet/src/column/writer/encoder.rs:
##########
@@ -145,16 +152,20 @@ impl<T: DataType> ColumnValueEncoderImpl<T> {
fn write_slice(&mut self, slice: &[T::T]) -> Result<()> {
if self.statistics_enabled != EnabledStatistics::None
- // INTERVAL has undefined sort order, so don't write min/max stats
for it
+ // INTERVAL, Geometry, and Geography have undefined sort order,so
don't write min/max stats for them
&& self.descr.converted_type() != ConvertedType::INTERVAL
{
- if let Some((min, max)) = self.min_max(slice, None) {
- update_min(&self.descr, &min, &mut self.min_value);
- update_max(&self.descr, &max, &mut self.max_value);
- }
+ if let Some(accumulator) = self.geo_stats_accumulator.as_mut() {
+ update_geo_stats_accumulator(accumulator.as_mut(),
slice.iter());
+ } else {
+ if let Some((min, max)) = self.min_max(slice, None) {
+ update_min(&self.descr, &min, &mut self.min_value);
+ update_max(&self.descr, &max, &mut self.max_value);
+ }
- if let Some(var_bytes) = T::T::variable_length_bytes(slice) {
- *self.variable_length_bytes.get_or_insert(0) += var_bytes;
+ if let Some(var_bytes) = T::T::variable_length_bytes(slice) {
+ *self.variable_length_bytes.get_or_insert(0) += var_bytes;
+ }
Review Comment:
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
