pitrou commented on code in PR #47573:
URL: https://github.com/apache/arrow/pull/47573#discussion_r2428886890
##########
cpp/src/arrow/util/bpacking_scalar_internal.h:
##########
@@ -23,7 +23,20 @@
namespace arrow::internal {
-ARROW_EXPORT int unpack32_neon(const uint8_t* in, uint32_t* out, int
batch_size,
+template <typename Uint>
+ARROW_EXPORT int unpack_scalar(const uint8_t* in, Uint* out, int batch_size,
int num_bits);
+extern template ARROW_TEMPLATE_EXPORT int unpack_scalar<uint8_t>(const
uint8_t*, uint8_t*,
Review Comment:
I don't think `ARROW_TEMPLATE_EXPORT` is useful, because this probably
wouldn't be called across DLL boundaries (or would it?).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
