alamb commented on code in PR #8582:
URL: https://github.com/apache/arrow-rs/pull/8582#discussion_r2422826447
##########
parquet/src/arrow/arrow_writer/mod.rs:
##########
@@ -886,69 +900,65 @@ impl ArrowRowGroupWriter {
/// Factory that creates new column writers for each row group in the Parquet
file.
pub struct ArrowRowGroupWriterFactory {
- schema: SchemaDescriptor,
+ schema: SchemaDescPtr,
arrow_schema: SchemaRef,
props: WriterPropertiesPtr,
#[cfg(feature = "encryption")]
file_encryptor: Option<Arc<FileEncryptor>>,
}
impl ArrowRowGroupWriterFactory {
- #[cfg(feature = "encryption")]
- fn new<W: Write + Send>(
+ /// Create a new [`ArrowRowGroupWriterFactory`] for the provided file
writer and Arrow schema
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
