justing-bq commented on code in PR #47703:
URL: https://github.com/apache/arrow/pull/47703#discussion_r2412046301
##########
cpp/src/arrow/flight/sql/odbc/odbc_impl/accessors/binary_array_accessor_test.cc:
##########
@@ -15,35 +15,32 @@
// specific language governing permissions and limitations
// under the License.
-#include "arrow/flight/sql/odbc/flight_sql/accessors/binary_array_accessor.h"
+#include "arrow/flight/sql/odbc/odbc_impl/accessors/binary_array_accessor.h"
#include "arrow/testing/builder.h"
#include "arrow/testing/gtest_util.h"
#include "gtest/gtest.h"
-namespace driver {
-namespace flight_sql {
-
-using arrow::BinaryType;
-using odbcabstraction::OdbcVersion;
+namespace arrow::flight::sql::odbc {
using arrow::ArrayFromVector;
+using arrow::BinaryType;
Review Comment:
Addressed.
##########
cpp/src/arrow/flight/sql/odbc/odbc_impl/accessors/date_array_accessor.cc:
##########
@@ -33,25 +35,19 @@ int64_t convertDate(typename T::value_type value) {
/// \return the converted value in seconds.
template <>
int64_t convertDate<Date64Array>(int64_t value) {
- return value / driver::odbcabstraction::MILLI_TO_SECONDS_DIVISOR;
+ return value / arrow::flight::sql::odbc::MILLI_TO_SECONDS_DIVISOR;
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
