scovich commented on code in PR #8600:
URL: https://github.com/apache/arrow-rs/pull/8600#discussion_r2442509104
##########
parquet-variant-compute/src/variant_get.rs:
##########
@@ -763,6 +764,13 @@ mod test {
BooleanArray::from(vec![Some(true), Some(false), Some(true)])
);
+ perfectly_shredded_to_arrow_primitive_test!(
+ get_variant_perfectly_shredded_utf8_as_utf8,
+ DataType::Utf8,
Review Comment:
@alamb -- I don't think it's difficult to support one vs. all of the string
and binary types (with help from a small trait) -- it was just a question of
whether it was legal. I tend to agree with you that it _is_ legal and we should
just move forward with it (possibly in this PR, since it's easy, or as a
follow-up, if preferred).
Would be nice if this made the arrow-57 cut.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
