amoeba commented on code in PR #3537:
URL: https://github.com/apache/arrow-adbc/pull/3537#discussion_r2430842914
##########
python/adbc_driver_manager/adbc_driver_manager/dbapi.py:
##########
@@ -195,11 +196,26 @@ def connect(
Parameters
----------
driver
- The driver name. For example, "adbc_driver_sqlite" will
- attempt to load libadbc_driver_sqlite.so on Linux systems,
- libadbc_driver_sqlite.dylib on MacOS, and
- adbc_driver_sqlite.dll on Windows. This may also be a path to
- the library to load.
+ The driver to use. This can be one of several values:
+
+ - A driver name or manifest name.
+
+ For example, "adbc_driver_sqlite" will first attempt to load
+ adbc_driver_sqlite.toml from the various search paths. Then, it
+ will try to load libadbc_driver_sqlite.so on Linux,
+ libadbc_driver_sqlite.dylib on MacOS, or adbc_driver_sqlite.dll on
+ Windows. See :doc:`/format/driver_manifests`.
+
+ - A full path to a shared library to load.
Review Comment:
```suggestion
- A relative or absolute path to a shared library to load.
```
Is this right?
##########
python/adbc_driver_manager/adbc_driver_manager/dbapi.py:
##########
@@ -195,11 +196,26 @@ def connect(
Parameters
----------
driver
- The driver name. For example, "adbc_driver_sqlite" will
- attempt to load libadbc_driver_sqlite.so on Linux systems,
- libadbc_driver_sqlite.dylib on MacOS, and
- adbc_driver_sqlite.dll on Windows. This may also be a path to
- the library to load.
+ The driver to use. This can be one of several values:
+
+ - A driver name or manifest name.
+
+ For example, "adbc_driver_sqlite" will first attempt to load
+ adbc_driver_sqlite.toml from the various search paths. Then, it
+ will try to load libadbc_driver_sqlite.so on Linux,
+ libadbc_driver_sqlite.dylib on MacOS, or adbc_driver_sqlite.dll on
Review Comment:
```suggestion
libadbc_driver_sqlite.dylib on macOS, or adbc_driver_sqlite.dll on
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
