findepi commented on code in PR #8417:
URL: https://github.com/apache/arrow-rs/pull/8417#discussion_r2376856880
##########
arrow-schema/src/field.rs:
##########
@@ -132,6 +132,12 @@ impl Hash for Field {
}
}
+impl AsRef<Field> for Field {
Review Comment:
Added a comment
```rust
// AsRef can be used in a function accepting a field.
// However, this case actually works a bit better when function takes
`&Field`
```
i agree that for a field-accepting function, `&Field` is a better type
choice.
Let's focus on
https://github.com/apache/arrow-rs/pull/8417#discussion_r2376849398. If we can
also solve this other problem, we don't need any code change!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
