jecsand838 commented on code in PR #8433:
URL: https://github.com/apache/arrow-rs/pull/8433#discussion_r2376992249
##########
arrow-avro/src/reader/record.rs:
##########
@@ -219,6 +220,10 @@ enum Decoder {
Boolean(BooleanBufferBuilder),
Int32(Vec<i32>),
Int64(Vec<i64>),
+ DurationSecond(Vec<i64>),
+ DurationMillisecond(Vec<i64>),
+ DurationMicrosecond(Vec<i64>),
+ DurationNanosecond(Vec<i64>),
Review Comment:
```suggestion
#[cfg(feature = "avro_custom_types")]
DurationSecond(Vec<i64>),
#[cfg(feature = "avro_custom_types")]
DurationMillisecond(Vec<i64>),
#[cfg(feature = "avro_custom_types")]
DurationMicrosecond(Vec<i64>),
#[cfg(feature = "avro_custom_types")]
DurationNanosecond(Vec<i64>),
```
If the feature flag is off, we'd just decode it as an `Int64`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
