alamb commented on PR #8543:
URL: https://github.com/apache/arrow-rs/pull/8543#issuecomment-3372229826
> > 🤖: Benchmark completed
> > Details
> > ```
> > group 8505-fix-from-iter
main
> > ----- ------------------
----
> > BooleanArray::from_iter 1.22 24.0±0.04µs ?
?/sec 1.00 19.6±0.02µs ? ?/sec
> > BooleanArray::from_trusted_len_iter 1.00 16.9±0.03µs ?
?/sec
> > Int64Array::from_iter 1.00 39.8±0.08µs ?
?/sec 1.00 40.0±0.14µs ? ?/sec
> > Int64Array::from_trusted_len_iter 1.01 19.0±0.05µs ?
?/sec 1.00 18.9±0.05µs ? ?/sec
> > [...]
> > ```
>
> Thanks! I think this is in-line with what I measured locally.
`BooleanArray::from_iter` is a bit slower, but the new
`BooleanArray::from_trusted_len_iter` is faster than the old implementation
(here 16.9 µs vs 19.6 µs) due to the use of unsafe.
Yes, I agree with your analysis -- and I think it is ok to take a hit of
performance to make it correct 🤣
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
