albertlockett commented on code in PR #8498:
URL: https://github.com/apache/arrow-rs/pull/8498#discussion_r2388897061
##########
arrow-array/src/builder/fixed_size_binary_dictionary_builder.rs:
##########
@@ -252,6 +252,28 @@ where
}
}
+ /// Append a value multiple times to the array.
+ /// This is the same as `append` but allows ot append the same value
multiple times without doing multiple lookups.
+ ///
+ /// Returns an error if the new index would overflow the key type.
Review Comment:
This is how we've documented the method on similar builders, so I was trying
to keep things consistent. I think the idea here is that it references the
`append` method, which documents the return type:
https://github.com/apache/arrow-rs/blob/17ce47cc4cbb29dd6b3fca904b6d606dcd202b45/arrow-array/src/builder/generic_bytes_dictionary_builder.rs#L293-L298
Should we fix the documentation on all dict array builders?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
