eric-wang-1990 commented on code in PR #3518:
URL: https://github.com/apache/arrow-adbc/pull/3518#discussion_r2403995940
##########
csharp/src/Drivers/Databricks/DatabricksStatement.cs:
##########
@@ -36,13 +36,16 @@ namespace Apache.Arrow.Adbc.Drivers.Databricks
/// </summary>
internal class DatabricksStatement : SparkStatement, IHiveServer2Statement
{
+ private const long DatabricksBatchSizeDefault = 2000000;
private bool useCloudFetch;
private bool canDecompressLz4;
private long maxBytesPerFile;
private bool enableMultipleCatalogSupport;
private bool enablePKFK;
private bool runAsyncInThrift;
+ public new long BatchSize { get; private set; } =
DatabricksBatchSizeDefault;
Review Comment:
Searching from web, this new keyword is hiding the base class impl, not
truly overriding it. Which means if the object is referenced by base class type
it will still call base class function.
Can we change the base to virtual so we can call this override?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
