nathaniel-d-ef commented on code in PR #8371:
URL: https://github.com/apache/arrow-rs/pull/8371#discussion_r2368245273
##########
arrow-avro/src/writer/mod.rs:
##########
@@ -84,6 +95,17 @@ impl WriterBuilder {
Some(json) => AvroSchema::new(json.clone()),
None => AvroSchema::try_from(&self.schema)?,
};
+
+ let maybe_fingerprint = if F::NEEDS_PREFIX {
+ match self.fingerprint_strategy {
+ FingerprintStrategy::Id(id) => Some(Fingerprint::Id(id)),
+ strategy =>
Some(avro_schema.fingerprint(FingerprintAlgorithm::from(strategy))?),
+ }
+ } else {
+ None
+ };
+ let maybe_prefix = maybe_fingerprint.as_ref().map(|fp|
fp.make_prefix());
Review Comment:
Doh, good catch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
