scovich commented on code in PR #8514:
URL: https://github.com/apache/arrow-rs/pull/8514#discussion_r2392891435
##########
parquet/tests/variant_integration.rs:
##########
@@ -65,8 +57,8 @@ macro_rules! variant_test_case {
// - cases 40, 42, 87, 127 and 128 are expected to fail always (they include
invalid variants)
// - the remaining cases are expected to (eventually) pass
-variant_test_case!(1, "Unshredding not yet supported for type: List(");
-variant_test_case!(2, "Unshredding not yet supported for type: List(");
+variant_test_case!(1);
+variant_test_case!(2);
Review Comment:
> Do I read this diff correctly that after this PR we handle all the test
cases other than Decimal?
I believe so!
> the reference to `https://github.com/apache/arrow-rs/issues/8329` above
`variant_test_case!(4);` is old and can be removed
Good catch! Fixed in https://github.com/apache/arrow-rs/pull/8481, since it
has nothing to do with variant arrays.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
