scovich commented on code in PR #8408:
URL: https://github.com/apache/arrow-rs/pull/8408#discussion_r2370551592
##########
parquet/src/arrow/schema/complex.rs:
##########
@@ -352,13 +353,13 @@ impl Visitor {
// Need both columns to be projected
match (maybe_key, maybe_value) {
- (Some(key), Some(value)) => {
+ (Some(mut key), Some(mut value)) => {
let key_field = Arc::new(
- convert_field(map_key, &key, arrow_key)
+ convert_field(map_key, &mut key, arrow_key)
// The key is always non-nullable (#5630)
.with_nullable(false),
);
- let value_field = Arc::new(convert_field(map_value, &value,
arrow_value));
+ let value_field = Arc::new(convert_field(map_value, &mut
value, arrow_value));
Review Comment:
Sorry, I don't think I understand this part of the code well enough to
suggest anything :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]