scovich commented on code in PR #8483:
URL: https://github.com/apache/arrow-rs/pull/8483#discussion_r2389340652
##########
parquet-variant-compute/src/arrow_to_variant.rs:
##########
@@ -400,39 +402,51 @@ define_row_builder!(
define_row_builder!(
struct Decimal32ArrowToVariantBuilder<'a> {
+ options: &'a CastOptions,
scale: i8,
},
|array| -> arrow::array::Decimal32Array { array.as_primitive() },
- |value| decimal_to_variant_decimal!(value, scale, i32, VariantDecimal4)
+ |value| -> Option<_> {
+ decimal_to_variant_decimal!(value, scale, i32,
VariantDecimal4).map(Variant::from)
Review Comment:
I don't think we need these `Variant::from` calls?
The builder `append_value` should take `impl Into<Variant>`
and we already define the needed `impl From<DecimalXX> for Variant`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
