kou commented on code in PR #3542:
URL: https://github.com/apache/arrow-adbc/pull/3542#discussion_r2415852821


##########
ci/docker/python-wheel-manylinux.dockerfile:
##########
@@ -15,24 +15,66 @@
 # specific language governing permissions and limitations
 # under the License.
 
-ARG ARCH
 ARG MANYLINUX
+FROM quay.io/pypa/manylinux${MANYLINUX}:latest
+
+ARG CMAKE=4.1.2
+ARG GO
+ARG NINJA=1.13.1
 ARG PYTHON
-ARG REPO
 ARG VCPKG
+ARG TARGETPLATFORM
 
-FROM 
${REPO}:${ARCH}-python-${PYTHON}-wheel-manylinux-${MANYLINUX}-vcpkg-${VCPKG}
-
-ARG ARCH
-ARG GO
+SHELL ["/bin/bash", "-i", "-c"]
+ENTRYPOINT ["/bin/bash", "-i", "-c"]
 
+# -------------------- System Dependencies --------------------
+# Some of these dependencies are needed to build things like OpenSSL in vcpkg
+RUN ulimit -n 1024 && yum install -y autoconf curl git flex perl-IPC-Cmd unzip 
wget yum-utils zip
 # docker is aliased to podman by AlmaLinux, but we want real Docker
 # (podman is just too different)
-RUN yum remove -y docker ; yum install -y yum-utils
+RUN ulimit -n 1024 && yum remove -y docker
 RUN yum-config-manager --add-repo 
https://download.docker.com/linux/centos/docker-ce.repo
-RUN yum install -y docker-ce docker-ce-cli containerd.io docker-buildx-plugin 
docker-compose-plugin
-# arm64v8 -> arm64
-RUN wget --no-verbose https://go.dev/dl/go${GO}.linux-${ARCH/v8/}.tar.gz && \
-    tar -C /usr/local -xzf go${GO}.linux-${ARCH/v8/}.tar.gz && \
-    rm go${GO}.linux-${ARCH/v8/}.tar.gz
+RUN ulimit -n 1024 && yum install -y docker-ce docker-ce-cli containerd.io 
docker-buildx-plugin docker-compose-plugin
+
+# -------------------- Python --------------------
+RUN PYTHON_ROOT=$(find /opt/python -name cp${PYTHON/./}-cp${PYTHON/./}) && \
+    echo "export PATH=$PYTHON_ROOT/bin:\$PATH" >> /etc/profile.d/python.sh
+ENV PATH="/opt/python/cp${PYTHON/./}-cp${PYTHON/./}/bin:${PATH}"
+
+# -------------------- CMake, Go --------------------
+RUN mkdir -p /.cache/go-build                         \
+    && chmod 777 /.cache/go-build                     \
+    && git config --global --add safe.directory /adbc \
+    && cp /root/.gitconfig /.gitconfig                \
+    && chmod 777 /.gitconfig
+
+RUN if [[ ${TARGETPLATFORM} == "linux/amd64" ]]; then                          
                                 \
+      export ARCH="amd64" CMAKE_ARCH=x86_64;                                   
                                 \

Review Comment:
   ```suggestion
           export ARCH="amd64" CMAKE_ARCH=x86_64;                               
                                   \
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to