liamzwbao commented on PR #8552: URL: https://github.com/apache/arrow-rs/pull/8552#issuecomment-3387882687
Hi @scovich, yeah, the core functionality we need is just `rescale_decimal`. I think it’s acceptable to duplicate the code for now, so I reverted the previous change and added only what we need in `type_conversion`. WDYT? Once #8580 is merged, I will apply the same fix here. The downside is that if we find a similar bug in the future, we’ll need to fix it in both places. But I think the refactor of `arrow-cast `would be better handled in a separate PR, and we can figure out how to reuse the code later -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
