etseidl commented on code in PR #8574:
URL: https://github.com/apache/arrow-rs/pull/8574#discussion_r2414725955
##########
parquet/src/file/metadata/memory.rs:
##########
@@ -56,6 +56,12 @@ impl<T: HeapSize> HeapSize for Arc<T> {
}
}
+impl<T: HeapSize> HeapSize for Box<T> {
+ fn heap_size(&self) -> usize {
+ self.as_ref().heap_size()
+ }
+}
Review Comment:
Not sure if this is correct. Should this also include the size of `T`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
