pitrou commented on code in PR #47573:
URL: https://github.com/apache/arrow/pull/47573#discussion_r2428884588
##########
cpp/src/arrow/util/bpacking_internal.h:
##########
@@ -23,17 +23,19 @@
namespace arrow::internal {
-/// The scalar 32 bit unpacking.
-ARROW_EXPORT int unpack32_scalar(const uint8_t* in, uint32_t* out, int
batch_size,
- int num_bits);
-
-/// The scalar 64 bit unpacking.
-ARROW_EXPORT int unpack64_scalar(const uint8_t* in, uint64_t* out, int
batch_size,
- int num_bits);
-
-ARROW_EXPORT
-int unpack32(const uint8_t* in, uint32_t* out, int batch_size, int num_bits);
-ARROW_EXPORT
-int unpack64(const uint8_t* in, uint64_t* out, int batch_size, int num_bits);
+template <typename Uint>
+ARROW_EXPORT int unpack(const uint8_t* in, Uint* out, int batch_size, int
num_bits);
+
+extern template ARROW_TEMPLATE_EXPORT int unpack<uint8_t>(const uint8_t*,
uint8_t*, int,
Review Comment:
I don't think `ARROW_TEMPLATE_EXPORT` is useful, this shouldn't be called
across DLL boundaries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
