scovich commented on code in PR #8611:
URL: https://github.com/apache/arrow-rs/pull/8611#discussion_r2430519205
##########
parquet-variant-compute/src/variant_array_builder.rs:
##########
@@ -162,6 +173,17 @@ impl VariantArrayBuilder {
}
}
+impl<'m, 'v> Extend<Option<Variant<'m, 'v>>> for VariantArrayBuilder {
+ fn extend<T: IntoIterator<Item = Option<Variant<'m, 'v>>>>(&mut self,
iter: T) {
Review Comment:
Ah, that makes sense for e.g. `From<Vec<bool>>`. They don't need an `Extend`
(not even a hidden one) because they just take over the input and are done.
Meanwhile, I guess `From<Vec<Option<bool>>>` will use `Extend<Option<bool>>`
under the hood, since that Vec can't be directly used?
##########
parquet-variant-compute/src/variant_array_builder.rs:
##########
@@ -162,6 +173,17 @@ impl VariantArrayBuilder {
}
}
+impl<'m, 'v> Extend<Option<Variant<'m, 'v>>> for VariantArrayBuilder {
+ fn extend<T: IntoIterator<Item = Option<Variant<'m, 'v>>>>(&mut self,
iter: T) {
Review Comment:
Ah, that makes sense for e.g. `From<Vec<bool>>`. They don't need an `Extend`
(not even a hidden one) because they just take over the input and are done.
Meanwhile, I guess `From<Vec<Option<bool>>>` will use `Extend<Option<bool>>`
under the hood, because that Vec can't be directly used?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
