hhhizzz commented on code in PR #8607:
URL: https://github.com/apache/arrow-rs/pull/8607#discussion_r2443009077
##########
parquet/src/arrow/record_reader/definition_levels.rs:
##########
@@ -284,20 +280,31 @@ impl PackedDecoder {
self.data_offset = 0;
}
- fn read(&mut self, buffer: &mut BooleanBufferBuilder, len: usize) ->
Result<usize> {
- let mut read = 0;
- while read != len {
+ /// Reads up to `len` definition levels directly into a boolean bitmask.
+ ///
+ /// Returns a tuple of `(values_read, levels_read)`, where `values_read`
counts the
+ /// number of `true` bits appended to `buffer`.
+ fn read(&mut self, buffer: &mut BooleanBufferBuilder, len: usize) ->
Result<(usize, usize)> {
Review Comment:
I reverted the change in `definition_levels.rs` because their performance is
unstable, it's only useful in some scenario.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
