jonkeane commented on a change in pull request #10056:
URL: https://github.com/apache/arrow/pull/10056#discussion_r616796505
##########
File path: r/tests/testthat/helper-expectation.R
##########
@@ -189,3 +187,109 @@ expect_vector_equal <- function(expr, # A vectorized R
expression containing `in
skip(paste(skip_msg, collpase = "\n"))
}
}
+
+expect_vector_equivalent <- function(expr, # A vectorized R expression
containing `input` as its input
Review comment:
➕ for renaming our `expect_vector` to avoid any possible confusion.
In other places I've been bitten by these testing helper name overlaps, and
each time it's happened it threw me for a loop trying to figure out what was
going wrong until I realized it was a name collision in a helper.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
